Skip to content

feat: badge api 연동 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 26, 2024
Merged

feat: badge api 연동 #85

merged 12 commits into from
Sep 26, 2024

Conversation

d0422
Copy link
Contributor

@d0422 d0422 commented Sep 25, 2024

  • badge api연동
  • badge click action주석처리
  • 커스텀 fallback 추가
  • 지도 이미지 번쩍거리는 문제 해결
  • 지도 이미지 crop하여 하드코딩으로 고정 렌더링 처리

image

image

지도문제

번쩍거리는 문제는 이미지를 hidden형태로 선언해두니 해결되었습니다.
근본적인 문제는 더 찾아봐야 하겠지만, 우선은 해결되어 PR넣습니다.

지도 대표이미지가 지도를 벗어나는 문제는 대표이미지를 받을때 정사각형 형태로 잘라서 업로드하고, 고정크기인 이미지를 보여주는 형태로 변경하였습니다.

@d0422 d0422 added the feat 새로운 기능 추가 label Sep 25, 2024
@d0422 d0422 self-assigned this Sep 25, 2024
@d0422 d0422 requested a review from HBSPS September 25, 2024 15:42
Copy link
Contributor

@HBSPS HBSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@d0422 d0422 merged commit b1be6af into main Sep 26, 2024
1 check passed
@d0422 d0422 deleted the feat/badge-api branch September 26, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants